frbvianna commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1971650236
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -170,19 +171,30 @@ func quoteTblName(name string) string {
return "\"" + strings.ReplaceAll(name, "\"", "\"\"") + "\""
}
+type DriverOption func(*gosnowflake.Config) error
+
+func WithTransporter(transporter http.RoundTripper) DriverOption {
+ return func(cfg *gosnowflake.Config) error {
+ cfg.Transporter = transporter
+ return nil
+ }
+}
+
type driverImpl struct {
driverbase.DriverImplBase
+
+ opts []DriverOption
}
// NewDriver creates a new Snowflake driver using the given Arrow allocator.
-func NewDriver(alloc memory.Allocator) adbc.Driver {
+func NewDriver(alloc memory.Allocator, opts ...DriverOption) adbc.Driver {
Review Comment:
Hi @lidavidm, if either option allow us to set the `http.RoundTripper` in
the underlying driver, but continue to work with the adbc.Database, that is
fine by me.
But to be sincere, this might only be useful for us if it can be delivered
as part of ADBC 17 (and if that is delivered around March-April). If not, then
we might have to go with using `gosnowflake` directly from the beginning and
probably won't make the switch to ADBC at any point in the near future (or
ever). It would be in our best interest though to use ADBC instead. Quite
unfortunately this is a blocker in our intended use.
Do you think that having a solution to this, such as the one proposed in the
PR or one suggested by you, is feasible for ADBC 17 target? I understand if
this is not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
