frbvianna commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1972174338
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -170,19 +171,30 @@ func quoteTblName(name string) string {
return "\"" + strings.ReplaceAll(name, "\"", "\"\"") + "\""
}
+type DriverOption func(*gosnowflake.Config) error
+
+func WithTransporter(transporter http.RoundTripper) DriverOption {
+ return func(cfg *gosnowflake.Config) error {
+ cfg.Transporter = transporter
+ return nil
+ }
+}
+
type driverImpl struct {
driverbase.DriverImplBase
+
+ opts []DriverOption
}
// NewDriver creates a new Snowflake driver using the given Arrow allocator.
-func NewDriver(alloc memory.Allocator) adbc.Driver {
+func NewDriver(alloc memory.Allocator, opts ...DriverOption) adbc.Driver {
Review Comment:
Sounds good to me. I would still keep the variadic `Option` and
`WithTransporter` functions so that new options can be implemented if ever
required, probably also adopting what I described in
https://github.com/apache/arrow-adbc/pull/2558#discussion_r1970203238. Do you
agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
