frbvianna commented on code in PR #2558:
URL: https://github.com/apache/arrow-adbc/pull/2558#discussion_r1971650236
##########
go/adbc/driver/snowflake/driver.go:
##########
@@ -170,19 +171,30 @@ func quoteTblName(name string) string {
return "\"" + strings.ReplaceAll(name, "\"", "\"\"") + "\""
}
+type DriverOption func(*gosnowflake.Config) error
+
+func WithTransporter(transporter http.RoundTripper) DriverOption {
+ return func(cfg *gosnowflake.Config) error {
+ cfg.Transporter = transporter
+ return nil
+ }
+}
+
type driverImpl struct {
driverbase.DriverImplBase
+
+ opts []DriverOption
}
// NewDriver creates a new Snowflake driver using the given Arrow allocator.
-func NewDriver(alloc memory.Allocator) adbc.Driver {
+func NewDriver(alloc memory.Allocator, opts ...DriverOption) adbc.Driver {
Review Comment:
Hi @lidavidm, if either option allow us to set the `http.RoundTripper` in
the underlying driver, but continue to work with the adbc.Database, that is
fine by me.
I'm guessing you mean something like
https://github.com/apache/arrow-adbc/pull/2563? Looks OK to me.
Do you think there is a chance this could be implemented for ADBC 17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
