stayrascal commented on PR #324: URL: https://github.com/apache/arrow-rs-object-store/pull/324#issuecomment-2799941234
> So I have done a first pass of a review, but unfortunately have run out of time for today. > > I wonder if we might be able to find someway to reduce the size of this diff, its really quite hard to review at the moment... Perhaps we could split adding list_opts and adding the max-keys into separate PRs? > > I also think we should try to make this not a breaking change, as it is unlikely we're going to look to make a breaking release in the next 4 or so months. Thanks a lot for got lots of useful suggestions from you, i will split the this diff and also avoid the breaking change, thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
