CurtHagenlocher commented on code in PR #2794:
URL: https://github.com/apache/arrow-adbc/pull/2794#discussion_r2096079678
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloadManager.cs:
##########
@@ -158,10 +158,7 @@ public CloudFetchDownloadManager(DatabricksStatement
statement, Schema schema, b
_resultQueue = new BlockingCollection<IDownloadResult>(new
ConcurrentQueue<IDownloadResult>(), prefetchCount * 2);
// Initialize the HTTP client
- _httpClient = new HttpClient
- {
- Timeout = TimeSpan.FromMinutes(timeoutMinutes)
- };
+ _httpClient = httpClient;
Review Comment:
After this change, it appears that the CloudFetchTimeoutMinutes parameter
isn't used any more. Should it be removed entirely? I don't have enough
experience with `HttpClient` to know how (or whether) a single client can be
used with different timeouts in different contexts.
##########
csharp/test/Drivers/Databricks/Auth/OAuthClientCredentialsProviderTests.cs:
##########
@@ -22,6 +22,7 @@
using Xunit;
using Xunit.Abstractions;
using Apache.Arrow.Adbc.Tests.Drivers.Databricks;
+using System.Net.Http;
Review Comment:
nit: sort usings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
