toddmeng-db commented on code in PR #2794:
URL: https://github.com/apache/arrow-adbc/pull/2794#discussion_r2096195885
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloadManager.cs:
##########
@@ -158,10 +158,7 @@ public CloudFetchDownloadManager(DatabricksStatement
statement, Schema schema, b
_resultQueue = new BlockingCollection<IDownloadResult>(new
ConcurrentQueue<IDownloadResult>(), prefetchCount * 2);
// Initialize the HTTP client
- _httpClient = new HttpClient
- {
- Timeout = TimeSpan.FromMinutes(timeoutMinutes)
- };
+ _httpClient = httpClient;
Review Comment:
I believe the CloudFetch Http Client and the other http clients are still
different HttpClients - so this commit
https://github.com/apache/arrow-adbc/pull/2794/commits/cd636cd14ba7ed62bf923f17f77618a8eccea69c
should only affect the CloudFetch http timeout?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]