CurtHagenlocher commented on code in PR #2794:
URL: https://github.com/apache/arrow-adbc/pull/2794#discussion_r2096186591
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloadManager.cs:
##########
@@ -158,10 +158,7 @@ public CloudFetchDownloadManager(DatabricksStatement
statement, Schema schema, b
_resultQueue = new BlockingCollection<IDownloadResult>(new
ConcurrentQueue<IDownloadResult>(), prefetchCount * 2);
// Initialize the HTTP client
- _httpClient = new HttpClient
- {
- Timeout = TimeSpan.FromMinutes(timeoutMinutes)
- };
+ _httpClient = httpClient;
Review Comment:
When we change the timeout on the shared client, it will also affect the
other users of the client -- including, I think, the polling to keep the
session alive and any subsequent commands issued for this connection. Does that
seem okay? Should it be reset once the cloud fetch is done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
