CurtHagenlocher commented on code in PR #2794:
URL: https://github.com/apache/arrow-adbc/pull/2794#discussion_r2096195698
##########
csharp/src/Drivers/Databricks/CloudFetch/CloudFetchDownloadManager.cs:
##########
@@ -158,10 +158,7 @@ public CloudFetchDownloadManager(DatabricksStatement
statement, Schema schema, b
_resultQueue = new BlockingCollection<IDownloadResult>(new
ConcurrentQueue<IDownloadResult>(), prefetchCount * 2);
// Initialize the HTTP client
- _httpClient = new HttpClient
- {
- Timeout = TimeSpan.FromMinutes(timeoutMinutes)
- };
+ _httpClient = httpClient;
Review Comment:
I think to support different timeouts on the same `HttpClient` they would
need to use the cancellation token on `GetAsync`, but if both
`HttpClient.Timeout` and a `CancellationToken` are used then whichever one
triggers first will cancel the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
