kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2099126961
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,15 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"19.1.0")
+ OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS
+ " -Wno-error=missing-template-arg-list-after-template-kw")
Review Comment:
It seems that we can suppress the detected memory leak
byhttps://github.com/apache/arrow/blob/main/cpp/build-support/lsan-suppressions.txt
.
https://github.com/apache/arrow/actions/runs/15148814357/job/42590835285?pr=46509#step:7:3962
```text
#9 0x7f0ea0c469af in __cxx_global_var_init
/build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep/sdk/src/trace/tracer.cc:42:5
```
https://github.com/open-telemetry/opentelemetry-cpp/blob/6175aa0b213eea053247e43b4f35b8d201fa356e/sdk/src/trace/tracer.cc#L41-L42
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4845,6 +4845,15 @@ macro(build_opentelemetry)
version)
set(OPENTELEMETRY_BUILD_BYPRODUCTS)
set(OPENTELEMETRY_LIBRARIES)
+ set(OPENTELEMETRY_CXX_FLAGS "${EP_CXX_FLAGS}")
+ # GH-46508: Supress warnings that won't be demoted by -Wno-error in recent
Clang.
+ if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"19.1.0")
+ OR (CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND
CMAKE_CXX_COMPILER_VERSION
+ VERSION_GREATER_EQUAL
"17.0.0"))
+ string(APPEND OPENTELEMETRY_CXX_FLAGS
+ " -Wno-error=missing-template-arg-list-after-template-kw")
Review Comment:
It seems that we can suppress the detected memory leak
byhttps://github.com/apache/arrow/blob/main/cpp/build-support/lsan-suppressions.txt
.
https://github.com/apache/arrow/actions/runs/15148814357/job/42590835285?pr=46509#step:7:3962
```text
#9 0x7f0ea0c469af in __cxx_global_var_init
/build/cpp/opentelemetry_ep-prefix/src/opentelemetry_ep/sdk/src/trace/tracer.cc:42:5
```
https://github.com/open-telemetry/opentelemetry-cpp/blob/v1.20.0/sdk/src/trace/tracer.cc#L41-L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
