IIFE commented on code in PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2106371782
########## c/cmake_modules/AdbcDefines.cmake: ########## @@ -143,6 +143,18 @@ endmacro() # Common testing setup add_custom_target(all-tests) if(ADBC_BUILD_TESTS) + if(MSVC) + # MSVC emitted warnings for testing code + add_compile_options(/wd5204) + add_compile_options(/wd5026) + add_compile_options(/wd4266) + add_compile_options(/wd4265) + add_compile_options(/wd5262) + add_compile_options(/wd4146) + add_compile_options(/wd4244) + add_compile_options(/wd4307) Review Comment: List sorted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
