IIFE commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2106375498


##########
c/cmake_modules/version.rc.in:
##########
@@ -0,0 +1,27 @@
+#include <windows.h>

Review Comment:
   I could but it won't make a difference to the values generated for the file 
properties. The main values being generated are the file description, version, 
company name, and product name. There is a Copyright property as well, so we 
could use that to include the Apache copyright, but it would be a small line of 
text (e.g., `Copyright (c) Apache`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to