IIFE commented on code in PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2107850902
########## c/cmake_modules/version.rc.in: ########## @@ -0,0 +1,27 @@ +#include <windows.h> + +VS_VERSION_INFO VERSIONINFO +FILEVERSION @ADBC_VERSION_MAJOR@,@ADBC_VERSION_MINOR@,@ADBC_VERSION_PATCH@,0 +PRODUCTVERSION @ADBC_VERSION_MAJOR@,@ADBC_VERSION_MINOR@,@ADBC_VERSION_PATCH@,0 +FILEFLAGSMASK VS_FFI_FILEFLAGSMASK +FILEFLAGS 0x0L +FILEOS VOS__WINDOWS32 +FILETYPE VFT_DLL +FILESUBTYPE VFT2_UNKNOWN Review Comment: It's the main file type value that makes sense for the produced files (DLLs). The rest are unrelated to the DLL file type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
