IIFE commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2106374488
##########
c/cmake_modules/BuildUtils.cmake:
##########
@@ -240,6 +240,21 @@ function(ADD_ARROW_LIB LIB_NAME)
OUTPUT_NAME ${LIB_NAME}
VERSION "${ADBC_FULL_SO_VERSION}"
SOVERSION "${ADBC_SO_VERSION}")
+
+ if(MSVC)
+ # Binaries generated on Windows need file version information,
otherwise when the binary is part of a Windows installer
+ # the installer won't know to update a previously installed version.
+ set(VERSION_RC_TEMPLATE
"${CMAKE_SOURCE_DIR}/cmake_modules/version.rc.in")
Review Comment:
Moved to c/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
