kou commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2120174018
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
Hmm. `EP_COMMON_CMAKE_ARGS` includes `-DCMAKE_CXX_FLAGS=${EP_CXX_FLAGS}`:
https://github.com/apache/arrow/blob/19aadb2ff09a2455064ba083c0fb0b626b651473/cpp/cmake_modules/ThirdpartyToolchain.cmake#L939
So I think that `EP_CXX_FLAGS` is used for OpenTelemetory C++ too without
these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
