kou commented on code in PR #46509: URL: https://github.com/apache/arrow/pull/46509#discussion_r2120168150
########## cpp/build-support/run-test.sh: ########## @@ -75,10 +75,9 @@ function setup_sanitizers() { UBSAN_OPTIONS="$UBSAN_OPTIONS suppressions=$ROOT/build-support/ubsan-suppressions.txt" export UBSAN_OPTIONS - # Enable leak detection even under LLVM 3.4, where it was disabled by default. - # This flag only takes effect when running an ASAN build. - # ASAN_OPTIONS="$ASAN_OPTIONS detect_leaks=1" - # export ASAN_OPTIONS + # Set up suppressions for AddressSanitizer + ASAN_OPTIONS="$ASAN_OPTIONS suppressions=$ROOT/build-support/asan-suppressions.txt" + export ASAN_OPTIONS Review Comment: OK. Could you add a comment to `asan-suppressions.txt` that this is an empty for now but it's expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org