zanmato1984 commented on code in PR #46509:
URL: https://github.com/apache/arrow/pull/46509#discussion_r2120158658
##########
cpp/build-support/lsan-suppressions.txt:
##########
@@ -26,3 +26,4 @@ leak:CRYPTO_zalloc
# without LSAN_OPTIONS=fast_unwind_on_malloc=0:malloc_context_size=100
leak:opentelemetry::v1::context::ThreadLocalContextStorage::GetStack
leak:opentelemetry::v1::context::ThreadLocalContextStorage::Stack::Resize
+leak:std::make_shared<opentelemetry::v1::trace::NoopTracer>
Review Comment:
This is still required to suppress the LSAN false-positive caused by partial
instrumentation.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
This is not necessary either. But I think it's nice to have, because it
didn't respect the `EP_CXX_FLAGS` as other bundled dependencies.
##########
cpp/build-support/run-test.sh:
##########
@@ -75,10 +75,9 @@ function setup_sanitizers() {
UBSAN_OPTIONS="$UBSAN_OPTIONS
suppressions=$ROOT/build-support/ubsan-suppressions.txt"
export UBSAN_OPTIONS
- # Enable leak detection even under LLVM 3.4, where it was disabled by
default.
- # This flag only takes effect when running an ASAN build.
- # ASAN_OPTIONS="$ASAN_OPTIONS detect_leaks=1"
- # export ASAN_OPTIONS
+ # Set up suppressions for AddressSanitizer
+ ASAN_OPTIONS="$ASAN_OPTIONS
suppressions=$ROOT/build-support/asan-suppressions.txt"
+ export ASAN_OPTIONS
Review Comment:
Sorry I forgot to mention. This is not necessary for this change but I think
we might need it in the future. What do you think?
##########
cpp/build-support/tsan-suppressions.txt:
##########
@@ -17,3 +17,6 @@
# Thread leak in CUDA
thread:libcuda.so
+
+# False-positives in OpenTelemetry because of non-instrumented code.
+race:^opentelemetry
Review Comment:
Ditto. Still needed. And we only disable the tests for ASAN. Other
sanitizers also have false-positives but can be suppressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
