khwilson commented on PR #44184: URL: https://github.com/apache/arrow/pull/44184#issuecomment-2945561960
Thanks, Rossi! My turn to apologize on tardiness. Will address this weekend. On Thu, Jun 5, 2025 at 1:41 PM Rossi Sun ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In cpp/src/arrow/compute/kernels/codegen_internal.cc > <https://github.com/apache/arrow/pull/44184#discussion_r2129530668>: > > > @@ -528,6 +533,28 @@ Status CastDecimalArgs(TypeHolder* begin, size_t count) { > return Status::OK(); > } > > +Result<std::shared_ptr<DataType>> WidenDecimalToMaxPrecision( > > Might want to add some test cases for this function in > codegen_internal_test.cc. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/44184#pullrequestreview-2901370679>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALU5EX7XE4NS3F6BSYIL5L3CB6MJAVCNFSM6AAAAABOVDOQEWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMBRGM3TANRXHE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
