khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2134818764
##########
cpp/src/arrow/compute/kernels/aggregate_basic.inc.cc:
##########
@@ -157,7 +157,7 @@ struct NullSumImpl : public NullImpl<ArrowType> {
}
};
-template <template <typename> class KernelClass>
+template <template <typename> class KernelClass, bool PromoteDecimal = true>
Review Comment:
In the end, each `Impl` ends up choosing whether it wants to promote the
decimal, so the code size consequence should be minimal. OTOH, the performance
implication either way should also be minimal. So I'm indifferent, which I
guess augurs for a runtime check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
