khwilson commented on code in PR #44184:
URL: https://github.com/apache/arrow/pull/44184#discussion_r2134828228
##########
cpp/src/arrow/compute/kernels/hash_aggregate_numeric.cc:
##########
@@ -42,7 +42,8 @@ namespace {
// Sum/Mean/Product implementation
template <typename Type, typename Impl,
- typename AccumulateType = typename FindAccumulatorType<Type>::Type>
+ typename AccumulateType = typename FindAccumulatorType<Type>::Type,
+ bool PromoteDecimal = false>
Review Comment:
Problem here is that `GetOutType` is `static` so creating a runtime check is
a bit of a nuisance without a larger refactor. And given that, maybe it's
better to be consistent between the two implementations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
