zeroshade commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2129852250
##########
go/adbc/driver/internal/driverbase/driver_info.go:
##########
@@ -43,6 +45,39 @@ var infoValueTypeCodeForInfoCode =
map[adbc.InfoCode]adbc.InfoValueTypeCode{
adbc.InfoVendorSubstraitMaxVersion: adbc.InfoValueStringType,
}
+const (
+ // namespace prefix
+ otelInfoSemConv = "apache.arrow.adbc.info."
Review Comment:
should we use
https://github.com/open-telemetry/opentelemetry-go/blob/v1.36.0/attribute/key.go#L8
instead of a raw string to have the extra methods for easier usage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
