zeroshade commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2129840013
##########
go/adbc/driver/internal/driverbase/database.go:
##########
@@ -392,7 +415,12 @@ func newTracerProvider(exporters ...sdktrace.SpanExporter)
(*sdktrace.TracerProv
),
)
if err != nil {
- return nil, err
+ // If unable to merge with the default resource (conflicting
ShhemaURL),
+ // use just our resource
+ mergedResource = resource.NewWithAttributes(
+ semconv.SchemaURL,
+ semconv.ServiceName(driverNamespace),
+ )
Review Comment:
are we just dropping the error? Should we log the error or otherwise only
ignore it conditionally based on what the error is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
