lidavidm commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2122349600
##########
go/adbc/driver/internal/driverbase/connection.go:
##########
@@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx
context.Context, infoCodes []adbc.In
} else {
strInfoBldr.AppendNull()
}
+ span.SetAttributes(attribute.String(code.String(), v))
Review Comment:
Why are we setting _all_ of the properties? And why are we using the raw
code as the attribute? IMO, if you do want to do this, we should only use
certain specific properties that we recognize (and use a friendly name) instead
of dumping everything into the span, to limit the cardinality. (Or going
further, using a fixed attribute and dumping the details we care about into the
value.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
