birschick-bq commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2121865120
##########
go/adbc/driver/internal/driverbase/connection.go:
##########
@@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx
context.Context, infoCodes []adbc.In
} else {
strInfoBldr.AppendNull()
}
+ span.SetAttributes(attribute.String(code.String(), v))
Review Comment:
@lidavidm - Let me know if you are OK with this change to add these metrics
for driver/server info, or you think I should remove it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
