superserious-dev commented on code in PR #7644:
URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2140479804
##########
parquet-variant/src/variant.rs:
##########
@@ -423,9 +434,33 @@ impl<'m, 'v> Variant<'m, 'v> {
VariantBasicType::Primitive => match get_primitive_type(header)? {
Review Comment:
All the decoders manually skip the first byte(header) in their
implementation. It could makes sense to just pass in the value with this first
byte removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
