superserious-dev commented on code in PR #7644:
URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2140469313
##########
parquet-variant/tests/variant_interop.rs:
##########
@@ -46,22 +47,22 @@ fn get_primitive_cases() -> Vec<(&'static str,
Variant<'static, 'static>)> {
// Cases are commented out
// Enabling is tracked in https://github.com/apache/arrow-rs/issues/7630
vec![
- // ("primitive_binary", Variant::Binary),
+ ("primitive_binary", Variant::Binary(&[0x03, 0x13, 0x37, 0xde, 0xad,
0xbe, 0xef, 0xca, 0xfe])),
("primitive_boolean_false", Variant::BooleanFalse),
("primitive_boolean_true", Variant::BooleanTrue),
- // ("primitive_date", Variant::Null),
- //("primitive_decimal4", Variant::Null),
- //("primitive_decimal8", Variant::Null),
- //("primitive_decimal16", Variant::Null),
- //("primitive_float", Variant::Null),
+ ("primitive_date", Variant::Date(NaiveDate::from_ymd_opt(2025, 4 ,
16).unwrap())),
+ ("primitive_decimal4", Variant::Decimal4{integer: 1234, scale: 2}),
+ ("primitive_decimal8", Variant::Decimal8{integer: 1234567890, scale:
2}),
+ ("primitive_decimal16", Variant::Decimal16{integer:
1234567891234567890, scale: 2}),
+ ("primitive_float", Variant::Float(1234567890.1234)),
("primitive_int8", Variant::Int8(42)),
- //("primitive_int16", Variant::Null),
- //("primitive_int32", Variant::Null),
- //("primitive_int64", Variant::Null),
+ ("primitive_int16", Variant::Int16(1234)),
+ ("primitive_int32", Variant::Int32(123456)),
+ ("primitive_int64", Variant::Int64(1234567890123456789)),
("primitive_null", Variant::Null),
("primitive_string", Variant::String("This string is longer than 64
bytes and therefore does not fit in a short_string and it also includes several
non ascii characters such as 🐢, 💖, ♥\u{fe0f}, 🎣 and 🤦!!")),
- //("primitive_timestamp", Variant::Null),
- //("primitive_timestampntz", Variant::Null),
+ ("primitive_timestamp",
Variant::TimestampMicros(NaiveDate::from_ymd_opt(2025, 4,
16).unwrap().and_hms_milli_opt(16, 34, 56, 780).unwrap().and_utc())),
Review Comment:
[`regen.py`](https://github.com/apache/parquet-testing/blob/b68bea40fed8d1a780a9e09dd2262017e04b19ad/variant/regen.py#L72)
has this as `2025-04-16T12:34:56.78` whereas it appears to be
`2025-04-16T16:34:56.78` in the test case `primitive_timestamp.value`(which is
the value that this test checks). I believe this is because the timezone is
treated as local to the computer that ran the regen script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
