etseidl commented on code in PR #7644:
URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2142731142
##########
parquet-variant/src/decoder.rs:
##########
@@ -33,7 +34,18 @@ pub enum VariantPrimitiveType {
BooleanTrue = 1,
BooleanFalse = 2,
Int8 = 3,
+ Int16 = 4,
+ Int32 = 5,
+ Int64 = 6,
+ Decimal4 = 8,
+ Decimal8 = 9,
+ Decimal16 = 10,
// TODO: Add types for the rest of primitives, once API is agreed upon
Review Comment:
It's still missing some primitive types (like `Double`, `UUID`) from the
[spec](https://github.com/apache/parquet-format/blob/master/VariantEncoding.md#encoding-types).
I'll admit to not following the variant development closely, but it seems the
TODO is still relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
