superserious-dev commented on code in PR #7644:
URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2140513158


##########
parquet-variant/src/variant.rs:
##########
@@ -483,6 +632,57 @@ impl<'m, 'v> From<i8> for Variant<'m, 'v> {
     }
 }
 
+impl<'m, 'v> From<i16> for Variant<'m, 'v> {

Review Comment:
   These `From<T>` impls could benefit from code coverage. Happy to add unit 
tests for these either in this PR or a future one. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to