zeroshade commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2159143985
########## c/driver_manager/adbc_driver_manager.cc: ########## @@ -15,26 +15,45 @@ // specific language governing permissions and limitations // under the License. -#include "arrow-adbc/adbc_driver_manager.h" +#if defined(_WIN32) +#include <windows.h> // Must come first Review Comment: When I google `_NOMINMAX` it looks like the pre-processor macro doesn't have the leading underscore in the results. Is it supposed to have the underscore or not? Also, I probably wouldn't want to add the define unless we actually do encounter the issue and need it personally. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
