zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2159156061
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -1716,6 +2176,12 @@ AdbcStatusCode AdbcLoadDriver(const char* driver_name,
const char* entrypoint,
return status;
}
+AdbcStatusCode AdbcLoadDriver(const char* driver_name, const char* entrypoint,
+ int version, void* raw_driver, struct AdbcError*
error) {
+ return AdbcFindLoadDriver(driver_name, entrypoint, version,
ADBC_LOAD_FLAG_DEFAULT,
+ raw_driver, error);
+}
Review Comment:
I would argue we should default to all options enabled so it searches
everywhere for the manifests and applications that use the driver would have to
explicitly disable search locations (opt-out, not opt-in). This way it ensures
that the default behavior is that the manifest files work and are easily found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
