lidavidm commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2160011573
########## c/driver_manager/adbc_driver_manager.cc: ########## @@ -15,26 +15,45 @@ // specific language governing permissions and limitations // under the License. -#include "arrow-adbc/adbc_driver_manager.h" +#if defined(_WIN32) +#include <windows.h> // Must come first Review Comment: Ah oops it's no underscore, right. I don't think it hurts though, since when it does occur the error message is often weird and I don't think there's ever a need to have the win32 min or max macros. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
