zanmato1984 commented on code in PR #46922:
URL: https://github.com/apache/arrow/pull/46922#discussion_r2174110073
##########
cpp/src/arrow/acero/CMakeLists.txt:
##########
@@ -129,6 +129,10 @@ if(ARROW_TESTING)
if(ARROW_WITH_OPENTELEMETRY)
target_link_libraries(arrow_acero_testing PRIVATE
${ARROW_OPENTELEMETRY_LIBS})
endif()
+ # arrow_compute_testing will register the kernels for Gtest. In order to
register the kernels
+ # for Google benchmark we use a custom main function used on
add_arrow_compute_benchmark.
+ set(ARROW_ACERO_BENCHMARKS_TEST_LINK_LIBS
+ ${ARROW_ACERO_TEST_LINK_LIBS} arrow_acero_testing
arrow_compute_core_testing)
Review Comment:
Shall we put this logic into `if(ARROW_BUILD_BENCHMARKS)` section down below
so that the benchmarking stuff is more collocated?
##########
cpp/src/arrow/dataset/CMakeLists.txt:
##########
@@ -207,8 +207,8 @@ if(ARROW_PARQUET)
endif()
if(ARROW_BUILD_BENCHMARKS)
- add_arrow_benchmark(file_benchmark PREFIX "arrow-dataset")
- add_arrow_benchmark(scanner_benchmark PREFIX "arrow-dataset")
+ add_arrow_compute_benchmark(file_benchmark PREFIX "arrow-dataset")
+ add_arrow_compute_benchmark(scanner_benchmark PREFIX "arrow-dataset")
Review Comment:
Feels weird of adding a dataset benchmark as "compute benchmark".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
