raulcd commented on code in PR #46922:
URL: https://github.com/apache/arrow/pull/46922#discussion_r2174383318
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -142,7 +182,9 @@ add_arrow_compute_test(row_test
EXTRA_LINK_LIBS
arrow_compute_testing)
-add_arrow_benchmark(function_benchmark PREFIX "arrow-compute")
+if(ARROW_BUILD_BENCHMARKS)
Review Comment:
I am not sure I understand what you mean. There are several places on the
code where we do have the
```
if (ARROW_BUILD_BENCHMARKS)
add_arrow_benchmark...
```
and in `add_benchmark` we don't have any check for `ARROW_BUILD_BENCHMARKS`,
are you suggesting to move the check to the `BuildUtils.cmake` function and
remove the checks throughout the code?
Examples:
https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/acero/CMakeLists.txt#L191
https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/dataset/CMakeLists.txt#L209-L211
https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/filesystem/CMakeLists.txt#L35-L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
