kou commented on code in PR #46922:
URL: https://github.com/apache/arrow/pull/46922#discussion_r2174416773
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -142,7 +182,9 @@ add_arrow_compute_test(row_test
EXTRA_LINK_LIBS
arrow_compute_testing)
-add_arrow_benchmark(function_benchmark PREFIX "arrow-compute")
+if(ARROW_BUILD_BENCHMARKS)
Review Comment:
Thanks for sharing existing examples.
The last example case is redundant. We can simply remove
`if(ARROW_BUILD_BENCHMARK)`.
https://github.com/apache/arrow/blob/953947a78157090ff94b14bc027cbcf520a5b2a6/cpp/src/arrow/filesystem/CMakeLists.txt#L35-L42
Other example cases: I think that we can remove `if(ARROW_BUILD_BENCHMARKS)`
by adding `EXTRA_PUBLIC_LINK_LIBS` to `add_arrow_benchmark()`.
I can do it as a separated task later. So you don't need to care about it in
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
