raulcd commented on code in PR #46922:
URL: https://github.com/apache/arrow/pull/46922#discussion_r2174504457
##########
cpp/src/arrow/compute/CMakeLists.txt:
##########
@@ -142,7 +182,9 @@ add_arrow_compute_test(row_test
EXTRA_LINK_LIBS
arrow_compute_testing)
-add_arrow_benchmark(function_benchmark PREFIX "arrow-compute")
+if(ARROW_BUILD_BENCHMARKS)
Review Comment:
ok, I understand now, I didn't know that the `NO_BENCHMARKS` variable was
basically mirroring `ARROW_BUILD_BENCHMARKS` and acting as the guard to build
those on `add_benchmark`, all clear now, I've removed the unnecessary if checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
