viirya commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2183252877
##########
parquet-variant/src/builder.rs:
##########
@@ -698,6 +734,15 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
///
/// This consumes self and writes the object to the parent buffer.
pub fn finish(mut self) -> Result<(), ArrowError> {
Review Comment:
> That only happens if there's an impl Drop tho:
Isn't what this PR does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
