scovich commented on PR #7843: URL: https://github.com/apache/arrow-rs/pull/7843#issuecomment-3032727248
> So I personally prefer the automatic finalize on drop behavior -- I can understand how that behavior can cause trouble when external resources are affected but in this case I think it makes this code much easier to use for most cases. Relating to the `?`-safety and unwind safety comment above: unconditionally finalizing on drop (hopefully) produces a physically valid variant -- but the result is still a logically invalid "torn write". That kind of spookiness is really hard to reason around when coding, and even harder to triage when something goes wrong. As I mentioned, I've hit this issue many times over the years, in various forms. It's always surprising and never in a good way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
