alamb commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2182935644
##########
parquet-variant/src/builder.rs:
##########
@@ -1452,6 +1510,9 @@ mod tests {
"Invalid argument error: Duplicate field keys detected: [x]"
);
+ inner_list.finish();
+ outer_list.finish();
+
Review Comment:
> In other words, it can achieve the effort to address the original issue
without the worries.
it does seem like the empty drop helps this one usecase
I will try and write a test that shows what happens when a builder isn't
finishd and we can evaluate the issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
