scovich commented on code in PR #7843:
URL: https://github.com/apache/arrow-rs/pull/7843#discussion_r2183026696
##########
parquet-variant/src/builder.rs:
##########
@@ -698,6 +734,15 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
///
/// This consumes self and writes the object to the parent buffer.
pub fn finish(mut self) -> Result<(), ArrowError> {
Review Comment:
That only happens if there's an `impl Drop` tho:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=fe049aba262d590948887ee08f43618c
Somehow, the compiler is able to shorten the lifetime of `outer_list` if
`impl Drop` doesn't get in the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
