alexguo-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2252739395
##########
csharp/src/Drivers/Databricks/DatabricksCompositeReader.cs:
##########
@@ -66,10 +63,16 @@ internal DatabricksCompositeReader(DatabricksStatement
statement, Schema schema,
_proxyConfigurator = proxyConfigurator;
// use direct results if available
- if (_statement.HasDirectResults && _statement.DirectResults !=
null && _statement.DirectResults.__isset.resultSet)
+ if (_statement.HasDirectResults && _statement.DirectResults !=
null && _statement.DirectResults.__isset.resultSet &&
statement.DirectResults?.ResultSet != null)
Review Comment:
Can this be simplified to `if (_statement.HasDirectResults)`? It looks like
that method is performing the same checks
##########
csharp/src/Drivers/Databricks/DatabricksOperationStatusPoller.cs:
##########
@@ -97,9 +98,20 @@ public void Dispose()
if (_internalCts != null)
{
_internalCts.Cancel();
- _operationStatusPollingTask?.Wait();
+ try
+ {
+ if (_operationStatusPollingTask != null)
Review Comment:
Similar, this check looks redundant because you are already doing
`_operationStatusPollingTask?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
