CurtHagenlocher commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2255012148
##########
csharp/src/Drivers/Databricks/DatabricksOperationStatusPoller.cs:
##########
@@ -69,13 +72,18 @@ private async Task PollOperationStatus(CancellationToken
cancellationToken)
var operationHandle = _statement.OperationHandle;
if (operationHandle == null) break;
Review Comment:
> @CurtHagenlocher will mashup ever trigger cancellationTokens passed into
IArrowStreamReader.ReadNextBatchAsync? Do we need to ensure that the connection
still remains usable for subsequent statements?
This is currently unimplemented but we'll need to implement it before GA for
parity with the ODBC implementation. What is probably most important for
cancellation is query execution, and unless we manage to push forward the
proposed ADBC 1.1 API, currently the only way to cancel a running query is to
call `AdbcStatement.Cancel`. There is currently no implementation of this
method for any of the C#-implemented drivers :(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
