jackyhu-db commented on code in PR #3217:
URL: https://github.com/apache/arrow-adbc/pull/3217#discussion_r2258649724
##########
csharp/src/Drivers/Databricks/DatabricksCompositeReader.cs:
##########
@@ -66,10 +63,16 @@ internal DatabricksCompositeReader(DatabricksStatement
statement, Schema schema,
_proxyConfigurator = proxyConfigurator;
// use direct results if available
- if (_statement.HasDirectResults && _statement.DirectResults !=
null && _statement.DirectResults.__isset.resultSet)
+ if (_statement.HasDirectResults && _statement.DirectResults !=
null && _statement.DirectResults.__isset.resultSet &&
statement.DirectResults?.ResultSet != null)
{
_activeReader =
DetermineReader(_statement.DirectResults.ResultSet);
+ if (!statement.DirectResults.ResultSet.HasMoreRows)
+ {
+ return;
+ }
Review Comment:
nit: return in the middle in the constructor may lead to some thing only
partially initialized? Can we do the other way around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
