lidavidm commented on code in PR #3604:
URL: https://github.com/apache/arrow-adbc/pull/3604#discussion_r2450440128
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -785,6 +785,8 @@ func buildField(schema *bigquery.FieldSchema, level uint)
(arrow.Field, error) {
field.Nullable = !schema.Required
metadata["Type"] = string(schema.Type)
Review Comment:
I would personally prefer we namespcae all the properties now that we want
to introduce this convention. Possibly we can keep the existing properties
under their current name with a deprecation notice.
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -785,6 +785,8 @@ func buildField(schema *bigquery.FieldSchema, level uint)
(arrow.Field, error) {
field.Nullable = !schema.Required
metadata["Type"] = string(schema.Type)
Review Comment:
I would personally prefer we namespace all the properties now that we want
to introduce this convention. Possibly we can keep the existing properties
under their current name with a deprecation notice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
