lidavidm commented on code in PR #3604:
URL: https://github.com/apache/arrow-adbc/pull/3604#discussion_r2454506249
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -785,6 +785,8 @@ func buildField(schema *bigquery.FieldSchema, level uint)
(arrow.Field, error) {
field.Nullable = !schema.Required
metadata["Type"] = string(schema.Type)
Review Comment:
That's not a law of physics, though. We can change things.
If you want to defer this to a separate PR, that's fine by me. But I think
they should be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]