felipecrv commented on code in PR #3604:
URL: https://github.com/apache/arrow-adbc/pull/3604#discussion_r2452161807
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -793,16 +802,22 @@ func buildField(schema *bigquery.FieldSchema, level uint)
(arrow.Field, error) {
return arrow.Field{}, err
}
metadata["PolicyTags"] = string(policyTagList)
+ metadata["BIGQUERY:policy_tags"] = string(policyTagList)
}
//
https://cloud.google.com/bigquery/docs/reference/storage#arrow_schema_details
switch schema.Type {
case bigquery.StringFieldType:
metadata["MaxLength"] = strconv.FormatInt(schema.MaxLength, 10)
+ metadata["BIGQUERY:max_length"] =
strconv.FormatInt(schema.MaxLength, 10)
Review Comment:
If we go in this direction, we should have a function that takes key,value
and converts the camelCase to snake_case generically to set the new key-value
pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
