serramatutu commented on code in PR #3604:
URL: https://github.com/apache/arrow-adbc/pull/3604#discussion_r2451780802
##########
go/adbc/driver/bigquery/connection.go:
##########
@@ -785,6 +785,8 @@ func buildField(schema *bigquery.FieldSchema, level uint)
(arrow.Field, error) {
field.Nullable = !schema.Required
metadata["Type"] = string(schema.Type)
Review Comment:
I am not sure if this should be split across two PRs though. IMO these
should be two separate changelog entries: one for standardizing the keys under
`BIGQUERY:...` and another for adding the new rich type key.
If that's the case I can merge the last commit first in a separate PR, then
rebase this one on top of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
