lidavidm commented on code in PR #885: URL: https://github.com/apache/arrow-java/pull/885#discussion_r2463182196
########## vector/src/test/java/org/apache/arrow/vector/TestMapVector.java: ########## Review Comment: I suppose it technically works but I find it very confusing to recycle the test, especially since the map value was always BigInt before. I'd rather see a new test that exercises both the key/value paths explicitly and is explicitly marked as a regression test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
