alamb commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r622045340
##########
File path: datafusion/src/execution/context.rs
##########
@@ -916,35 +898,6 @@ mod tests {
Ok(())
}
- #[tokio::test]
- async fn create_variable_expr() -> Result<()> {
Review comment:
I think these were added in https://github.com/apache/arrow/pull/8135 .
Perhaps @wqc200 has some comment about how / if this feature is used?
##########
File path: datafusion/src/sql/parser.rs
##########
@@ -21,7 +21,7 @@
use sqlparser::{
ast::{ColumnDef, ColumnOptionDef, Statement as SQLStatement,
TableConstraint},
- dialect::{keywords::Keyword, Dialect, GenericDialect},
+ dialect::{keywords::Keyword, Dialect, PostgreSqlDialect},
Review comment:
Another approach might be to make the SQL dialect be configurable on
`ExecutionConfig` so that users could choose what dialect they wanted to mimic:
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/execution/context.rs#L606
I think @andygrove has said in the past using DataFusion to mimic engines
such as MySQL is a good usecase too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
