returnString commented on a change in pull request #214:
URL: https://github.com/apache/arrow-datafusion/pull/214#discussion_r622139244
##########
File path: datafusion/src/sql/parser.rs
##########
@@ -21,7 +21,7 @@
use sqlparser::{
ast::{ColumnDef, ColumnOptionDef, Statement as SQLStatement,
TableConstraint},
- dialect::{keywords::Keyword, Dialect, GenericDialect},
+ dialect::{keywords::Keyword, Dialect, PostgreSqlDialect},
Review comment:
Thinking about it more over lunch: if we enable a bring-your-own-dialect
setup, we'd need a decent testing strategy to support this. In this example,
`@someval` will be parsed as `UnaryOp { op: PGAbs, expr: Ident("someval") }`
for Postgres, so we'd need to decide how we implement DF-specific parsing
overrides, e.g. as used to support this var provider system, on a per-dialect
basis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
