ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r622506510
##########
File path: r/R/compute.R
##########
@@ -284,3 +284,14 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+#' @export
+strsplit <- function(x, split, fixed = TRUE, perl = FALSE, useBytes = FALSE,
...) UseMethod("strsplit")
+
+#' @export
+strsplit.default <- base::strsplit
Review comment:
Since `strsplit()` is not a generic, this is the only way we can make it
usable in standard evaluation. But this will generate an additional message
when Arrow loads:
```
The following object is masked from ‘package:base’:
strsplit
```
I believe we want to avoid masking any more functions like this—is that
correct @nealrichardson?
The alternative is to make `strsplit()` usable only in dplyr verbs.
Non-standard evaluation allows us to do that without any masking issues. To do
that, you add a mapping here:
https://github.com/apache/arrow/blob/master/r/R/dplyr.R#L396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
