nealrichardson commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r622509355
##########
File path: r/R/compute.R
##########
@@ -284,3 +284,14 @@ cast_options <- function(safe = TRUE, ...) {
)
modifyList(opts, list(...))
}
+
+#' @export
+strsplit <- function(x, split, fixed = TRUE, perl = FALSE, useBytes = FALSE,
...) UseMethod("strsplit")
+
+#' @export
+strsplit.default <- base::strsplit
Review comment:
Correct, we don't want to mask. We should just wire this up in the dplyr
verbs as @ianmcook suggests. `nchar()` on L448 there could be a good model to
follow, or perhaps sub/gsub if you need more complexity. Likewise, we'll want
to add something for the stringr versions of this (str_split, str_split_fixed?)
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]